Skip to content

pass dependencies to toolchain.prepare when setting up build environment for extensions#5023

Merged
bedroge merged 3 commits intoeasybuilders:developfrom
boegel:toolchain_prepare_deps_extensions
Oct 22, 2025
Merged

pass dependencies to toolchain.prepare when setting up build environment for extensions#5023
bedroge merged 3 commits intoeasybuilders:developfrom
boegel:toolchain_prepare_deps_extensions

Conversation

@boegel
Copy link
Member

@boegel boegel commented Oct 9, 2025 •
edited
Loading

fix for build problem with scipy in EESSI 2025.06, where EasyBuild is configured with search-path-cpp-headers set to include_paths

see also EESSI/software-layer#1216

$C_INCLUDE_PATH gets set to only paths of toolchain components, because list of dependencies is not passed to toolchain.prepare when build environment is set up for installing an extension

draft PR since I would like to come up with a test that catches this bug...

@boegel boegel added this to the next release (5.2.0?) milestone Oct 9, 2025
@boegel boegel added bug fix EESSI Related to EESSI project labels Oct 9, 2025
@boegel boegel changed the title pass dependencies to toolchain.prepare when setting up build environment for extensions pass dependencies to toolchain.prepare when setting up build environment for extensions Oct 9, 2025
@boegel boegel mentioned this pull request Oct 9, 2025
Closed
@boegel boegel mentioned this pull request Oct 22, 2025
Closed
@boegel boegel marked this pull request as ready for review October 22, 2025 13:04
@boegel
Copy link
Member Author

boegel commented Oct 22, 2025

Test that verifies this fix has been added in e69baba

@boegel boegel requested a review from bedroge October 22, 2025 13:05
@bedroge
Copy link
Contributor

bedroge commented Oct 22, 2025

@boegel Lgtm, only wondering if we should do the same test for the other header search options, as they are also affected (though the solution should solve it for all options)? Can we easily parameterize the test for --search-path-cpp-headers=[flags,cpath,include_paths] and check the value of respectively [CPPFLAGS, CPATH, C_INCLUDE_PATH / CPLUS_INCLUDE_PATH]?

@boegel
Copy link
Member Author

boegel commented Oct 22, 2025

@boegel Lgtm, only wondering if we should do the same test for the other header search options, as they are also affected (though the solution should solve it for all options)? Can we easily parameterize the test for --search-path-cpp-headers=[flags,cpath,include_paths] and check the value of respectively [CPPFLAGS, CPATH, C_INCLUDE_PATH / CPLUS_INCLUDE_PATH]?

@bedroge Good idea, that's indeed pretty easy to do, done in f9e1af1

bedroge
bedroge approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@bedroge bedroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@bedroge bedroge enabled auto-merge October 22, 2025 17:59
@bedroge bedroge merged commit 5bad7d7 into easybuilders:develop Oct 22, 2025
39 checks passed
@boegel boegel deleted the toolchain_prepare_deps_extensions branch October 22, 2025 20:34
This was referenced Nov 12, 2025
Merged
Merged
@ocaisa ocaisa mentioned this pull request Feb 19, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bedroge bedroge bedroge approved these changes

Assignees

No one assigned

Labels

bug fix EESSI Related to EESSI project

Projects

None yet

Milestone

5.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @bedroge

Comments